zhangstar333 commented on code in PR #53118:
URL: https://github.com/apache/doris/pull/53118#discussion_r2222360853
##########
be/src/vec/aggregate_functions/aggregate_function_approx_top_sum.cpp:
##########
@@ -28,23 +28,23 @@ namespace doris::vectorized {
template <size_t N>
AggregateFunctionPtr create_aggregate_function_multi_top_sum_impl(
const DataTypes& argument_types, const bool result_is_nullable,
- const std::vector<std::string>& column_names) {
+ const AggregateFunctionAttr& attr) {
if (N == argument_types.size() - 3) {
return creator_with_integer_type_with_index<N>::template create<
- AggregateFunctionApproxTopSumSimple>(argument_types,
result_is_nullable,
- column_names);
+ AggregateFunctionApproxTopSumSimple>(argument_types,
result_is_nullable, attr,
Review Comment:
it's seems need change more code to do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
