zhangstar333 commented on code in PR #53118:
URL: https://github.com/apache/doris/pull/53118#discussion_r2224193184


##########
be/src/vec/aggregate_functions/aggregate_function_null.h:
##########
@@ -73,14 +80,41 @@ class AggregateFunctionNullBaseInline : public 
IAggregateFunctionHelper<Derived>
         return result_is_nullable ? place[0] : true;
     }
 
+    static void init_null_count(AggregateDataPtr __restrict place) noexcept {
+        if constexpr (result_is_nullable) {

Review Comment:
   the caller have check is_window_function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to