yiguolei commented on code in PR #60367:
URL: https://github.com/apache/doris/pull/60367#discussion_r2772224395


##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -854,7 +898,49 @@ size_t PipelineTask::get_revocable_size() const {
         return 0;
     }
 
-    return _sink->revocable_mem_size(_state);
+    size_t revocable_size = _sink->revocable_mem_size(_state);
+
+    for (const auto& op : _operators) {
+        revocable_size += op->revocable_mem_size(_state);
+    }
+
+    return revocable_size;
+}
+
+bool PipelineTask::should_trigger_revoking(const size_t reserve_size) const {

Review Comment:
   private 的方法都用_ 开头



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to