mrhhsg commented on code in PR #60367:
URL: https://github.com/apache/doris/pull/60367#discussion_r2772971524
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -641,7 +674,17 @@ Status PipelineTask::do_revoke_memory(const
std::shared_ptr<SpillContext>& spill
}
}};
- return _sink->revoke_memory(_state, spill_context);
+ RETURN_IF_ERROR(_sink->revoke_memory(_state, nullptr));
+
+ for (const auto& op : _operators) {
+ RETURN_IF_ERROR(op->revoke_memory(_state, nullptr));
+ }
+
+ if (spill_context) {
+ spill_context->on_task_finished();
Review Comment:
之前是在 sink 的 revoke_memory 里调用的，但现在非 sink operator 也支持里 revoke_memory
接口，就统一在这里调用了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
