github-actions[bot] commented on code in PR #60567:
URL: https://github.com/apache/doris/pull/60567#discussion_r3135831014
##########
gensrc/thrift/FrontendService.thrift:
##########
@@ -202,6 +202,9 @@ struct TQueryStatistics {
12: optional i64 spill_write_bytes_to_local_storage
13: optional i64 spill_read_bytes_from_local_storage
14: optional i64 bytes_write_into_cache
Review Comment:
This PR adds `process_rows`, `finished_tasks_num`, and `total_tasks_num` to
`TQueryStatistics`, and `show proc '/current_queries'` now depends on those
fields. But `ProfileManager.getQueryStatistic()` still only aggregates the
older fields before serving `/rest/v2/manager/query/statistics/{trace_id}`. As
a result, the dedicated runtime-statistics API silently drops the new counters
and disagrees with the proc output introduced by this change. Please update
that FE aggregation path and the REST response DTO together with the thrift
extension so all query-stat surfaces stay consistent.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryInfoProvider.java:
##########
@@ -69,60 +55,72 @@ public Map<String, QueryStatistics>
getQueryStatistics(Collection<QueryStatistic
Review Comment:
`collectInstanceProfile()` now supports both the old `"Instance <id> ..."`
layout and the new task-level `FragmentInstanceId` tags, but this branch still
assumes the legacy shape is mutually exclusive with any task-tagged descendants
(`checkState(profiles == null)`). That is not guaranteed during rolling upgrade
/ mixed-profile scenarios: FE can already hold an existing legacy instance node
from an earlier report, then receive a later report whose task profiles carry
`FragmentInstanceId`, and the recursive walk reaches both for the same instance
id. In that case `show proc '/current_queries/<query_id>/fragments'` will start
throwing `IllegalStateException` instead of preserving compatibility. Please
merge the legacy node into the existing list (or ignore it once task-tagged
profiles exist) rather than asserting uniqueness here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
