github-actions[bot] commented on code in PR #60567:
URL: https://github.com/apache/doris/pull/60567#discussion_r3136040611
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryInfoProvider.java:
##########
@@ -133,8 +131,14 @@ public QueryStatistics(RuntimeProfile profile) {
collectCounters(profile, counterMaps);
}
- private void collectCounters(RuntimeProfile profile,
- List<Map<String, Counter>>
counterMaps) {
+ public QueryStatistics(Collection<RuntimeProfile> profiles) {
Review Comment:
Now that task-tagged pipeline profiles are funneled through , this path also
needs to read the row counter name that BE actually emits. records row counts
as (, ), and FE's own profile merge logic already treats as the actual
output-row counter (). But below still only sums , so keeps showing for
task-based profiles even after BE reports succeed. The new unit test passes
only because it synthesizes counters instead of the real BE output. Please
read here (or both names for compatibility) and add a test that uses the
BE-emitted counter name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
