github-actions[bot] commented on code in PR #63161: URL: https://github.com/apache/doris/pull/63161#discussion_r3223651063
########## regression-test/data/datatype_p0/timestamptz/test_timestamptz_utc_functions.out: ########## @@ -0,0 +1,19 @@ +-- This file is automatically generated. You should know what you did if you want to edit this +-- !timestamptz_diff_utc -- +600000 600000000 600 10 0 0 0 0 0 0 0 00:10:00.000000 + +-- !timestamptz_diff_ny -- +600000 600000000 600 10 0 0 0 0 0 0 0 00:10:00.000000 + +-- !timestamptz_agg_utc -- +true 1 2 2 + +-- !timestamptz_agg_ny -- +true 1 2 2 + +-- !timestamptz_topn_weighted -- Review Comment: The expected output file is incomplete for the suite that was added. `test_timestamptz_utc_functions.groovy` defines 10 result-producing cases (`qt_timestamptz_diff_spring_forward_ny`, `qt_timestamptz_diff_mixed_scale_ny`, `order_qt_timestamptz_agg_by_group_ny`, `qt_timestamptz_column_diff_ny`, etc.), but this `.out` only contains 6 labels. The `topn_weighted` case is also expected to return `grp`, `top_ts`, and `top_ts_with_default` for two groups, while the checked-in output has a single timestamp column and one row. Please regenerate this `.out` from the regression runner so the new suite can pass and actually verify the added UTC semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
