Mryange commented on code in PR #63161:
URL: https://github.com/apache/doris/pull/63161#discussion_r3225408866
##########
be/src/exprs/aggregate/aggregate_function_sequence_match.h:
##########
@@ -73,10 +73,10 @@ constexpr auto sequence_match_max_iterations = 1000000l;
template <PrimitiveType T, typename Derived>
struct AggregateFunctionSequenceMatchData final {
using Timestamp = typename PrimitiveTypeTraits<T>::CppType;
- using NativeType =
- std::conditional_t<T == TYPE_DATEV2, uint32_t,
- std::conditional_t<T == TYPE_DATETIMEV2,
uint64_t,
- typename
PrimitiveTypeTraits<T>::CppType>>;
+ using NativeType = std::conditional_t<
Review Comment:
我怀疑这个地方就是错的。。。
```
这个 NativeType 在 AggregateFunctionSequenceMatchData 里只用了一处：
NativeType duration = 0;
if (!parse_uint(duration)) {
...
}
actions.emplace_back(type, duration);
也就是只用于解析 (?t<=xxx) 里的 xxx。解析完以后马上被塞进：
struct PatternAction final {
PatternActionType type;
std::uint64_t extra;
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
