FayneBupt commented on code in PR #62689:
URL: https://github.com/apache/doris/pull/62689#discussion_r3226087058


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -346,6 +346,289 @@ void FragmentMgr::stop() {
     }
 }
 
+std::string FragmentMgr::to_http_path(const std::string& file_name) {
+    std::stringstream url;
+    url << "http://"; << BackendOptions::get_localhost() << ":" << 
config::webserver_port
+        << "/api/_download_load?"
+        << "token=" << _exec_env->token() << "&file=" << file_name;
+    return url.str();
+}
+
+Status FragmentMgr::trigger_pipeline_context_report(
+        const ReportStatusRequest req, 
std::shared_ptr<PipelineFragmentContext>&& ctx) {
+    return _thread_pool->submit_func([this, req, ctx]() {
+        SCOPED_ATTACH_TASK(ctx->get_query_ctx()->query_mem_tracker());
+        coordinator_callback(req);
+        if (!req.done) {
+            ctx->refresh_next_report_time();
+        }
+    });
+}
+
+// There can only be one of these callbacks in-flight at any moment, because
+// it is only invoked from the executor's reporting thread.
+// Also, the reported status will always reflect the most recent execution 
status,
+// including the final status when execution finishes.
+void FragmentMgr::coordinator_callback(const ReportStatusRequest& req) {

Review Comment:
   感谢提醒,这里确实不应该改 FragmentMgr。这部分是分支适配时带进来的重复逻辑,我已经去掉了。当前 PR 不再修改 
be/src/runtime/fragment_mgr.cpp / fragment_mgr.h,Paimon commit message 仍然走现有 
pipeline report status 流程处理。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to