FayneBupt commented on code in PR #62689:
URL: https://github.com/apache/doris/pull/62689#discussion_r3226091191
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -1877,6 +1886,16 @@ bool PipelineFragmentContext::_close_fragment_instance()
{
Defer defer_op {[&]() { _is_fragment_instance_closed = true; }};
_fragment_level_profile->total_time_counter()->update(_fragment_watcher.elapsed_time());
if (!_need_notify_close) {
+ if (_runtime_state) {
+ for (auto& tasks : _tasks) {
+ for (auto& task : tasks) {
+ if
(!task.first->runtime_state()->paimon_commit_messages().empty()) {
+ _runtime_state->add_paimon_commit_messages(
Review Comment:
感谢提醒，我对齐了一下已有 writer 的处理方式。这里不再遍历 _tasks 主动收集 Paimon commit message，避免在
close 流程里做特殊处理。现在 Paimon commit message 和 Iceberg/MaxCompute 一样，在
_coordinator_callback() 里从 RuntimeState 填充到 report status 参数中上报。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
