github-actions[bot] commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3231489270
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -2110,7 +2110,7 @@ private void validateFlexiblePartialUpdateForAlter()
throws UserException {
}
OlapTable olapTable = (OlapTable) table;
- // Validate table-level constraints (MoW, skip_bitmap,
light_schema_change, variant columns)
+ // Validate table-level constraints (MoW, skip_bitmap,
light_schema_change)
Review Comment:
This alter-time validation still checks only the job's current
format/jsonpaths/fuzzy/COLUMNS state, and it only runs when the ALTER statement
includes `unique_key_update_mode`. A job that is already
`UPDATE_FLEXIBLE_COLUMNS` can be altered with `jsonpaths`, `fuzzy_parse=true`,
or a `COLUMNS` clause, because `KafkaRoutineLoadJob.modifyProperties()` calls
this helper before applying `copiedJobProperties`, and `RoutineLoadManager`
installs the new `RoutineLoadDesc` afterward. A single ALTER that changes the
mode to `UPDATE_FLEXIBLE_COLUMNS` and also supplies `jsonpaths` has the same
problem: this helper validates the old descriptor, then the new invalid
descriptor is installed. For VARIANT flexible partial update that means the BE
can enter the jsonpath writer path, which does not append/mark the hidden skip
bitmap for omitted columns, so missing VARIANT cells are default-filled instead
of being treated as skipped patches. Please validate the post-ALTER effective
routine-load proper
ties and descriptor whenever the resulting job mode is
`UPDATE_FLEXIBLE_COLUMNS`, not only when the mode property is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
