eldenmoon commented on code in PR #63182:
URL: https://github.com/apache/doris/pull/63182#discussion_r3232030733
##########
be/src/exec/common/variant_util.cpp:
##########
@@ -2141,6 +2146,627 @@ phmap::flat_hash_map<std::string_view,
ColumnVariant::Subcolumn> materialize_doc
return subcolumns;
}
+constexpr uint64_t VARIANT_PATCH_PATH_MARKER_MASK = 1ULL << 63;
Review Comment:
这里需要保留精确 patch path：flush 阶段已经把 patch 合成 full VARIANT，publish conflict
时如果只看到 full value，就不能反推出哪些 path 是本事务声明的、哪些 path 是旧值补出来的。用 hash/path id 要额外
sidecar/dictionary 一直带到 publish 阶段，侵入面更大；当前 marker 虽然看起来多，但只局限在 flexible update
的 skip bitmap 里，并且有 256 paths / 4KB encoded path bytes 的上限。v1
我倾向保持这个局部编码，不再引入新的跨阶段状态。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
