yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3271685130
##########
be/src/core/column/column_dictionary.h:
##########
@@ -326,26 +318,13 @@ class ColumnDictI32 final : public COWHelper<IColumn,
ColumnDictI32> {
}
}
- inline uint32_t get_hash_value(Int32 code, FieldType type) const {
Review Comment:
template <typename fixed_len_to_uint32_method, typename T, bool need_trim =
false>
uint16_t find_batch_olap(const BloomFilterAdaptor& bloom_filter, const char*
data,
const uint8_t* nullmap, uint16_t* offsets, int
number,
const bool is_parse_column) {
auto get_element = [](const char* input_data, int idx) {
if constexpr (std::is_same_v<T, StringRef> && need_trim) {
const auto value = ((const StringRef*)(input_data))[idx];
int64_t size = value.size;
const char* data = value.data;
// CHAR type may pad the tail with \0, need to trim
while (size > 0 && data[size - 1] == '\0') {
size--;
}
return StringRef(value.data, size);
} else {
return ((const T*)(input_data))[idx];
}
}; 这段代码也需要改一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
