yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3271712171
##########
be/src/core/column/predicate_column.h:
##########
@@ -104,18 +104,22 @@ class PredicateColumnType final : public
COWHelper<IColumn, PredicateColumnType<
StringRef get_data_at(size_t n) const override {
if constexpr (std::is_same_v<T, StringRef>) {
- auto res = reinterpret_cast<const StringRef&>(data[n]);
- if constexpr (Type == TYPE_CHAR) {
- res.size = strnlen(res.data, res.size);
- }
- return res;
+ return reinterpret_cast<const StringRef&>(data[n]);
} else {
throw doris::Exception(
ErrorCode::INTERNAL_ERROR,
"should not call get_data_at in predicate column except
for string type");
}
}
+ void shrink_padding_chars() override {
Review Comment:
这里insert 到 这个predicate column的时候，没有把char 末尾的0 去掉？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
