yujun777 commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3340106289
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -4041,4 +4034,36 @@ public void createTableStream(CreateStreamCommand
command) throws DdlException {
LOG.info("successfully create stream[{}]", streamName);
}
}
+
+ void checkBaseTableAvailable(TableIf tableIf) throws DdlException {
+ if (!BaseTableStream.isTableTypeSupported(tableIf)) {
+ throw new DdlException("Base table type " + tableIf.getType()
+ + " is not supported for create table stream");
+ }
+ if (tableIf instanceof OlapTable) {
+ OlapTable olapTable = (OlapTable) tableIf;
+ if (!olapTable.needRowBinlog()) {
+ throw new DdlException("Base Olap table " +
olapTable.getQualifiedName()
+ + " need to enable row binlog for table stream");
+ }
+ }
+ }
+
+ void checkBaseTableAvailableForStreamType(OlapTable olapTable,
BaseTableStream.StreamScanType streamScanType)
+ throws DdlException {
+ if (streamScanType != BaseTableStream.StreamScanType.DEFAULT
+ && streamScanType != BaseTableStream.StreamScanType.MIN_DELTA)
{
+ return;
+ }
+ if (!olapTable.isUniqKeyMergeOnWrite()) {
Review Comment:
can dup table compatitle with MIN_DELTA ? maybe dup table can allow
MIN_DELTA and APPEND_ONLY， and they are the same for dup table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
