yujun777 commented on code in PR #63850:
URL: https://github.com/apache/doris/pull/63850#discussion_r3340160958
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##########
@@ -447,6 +489,145 @@ private Optional<LogicalPlan> handleMetaTable(TableIf
table, UnboundRelation unb
return Optional.of(new
LogicalTVFRelation(unboundRelation.getRelationId(), tvf, ImmutableList.of()));
}
+ private ChangeScanInfo buildChangeScanInfo(TableScanParams scanParams) {
+ ChangeScanInfo.InformationKind informationKind
+ = ChangeScanInfo.InformationKind.DETAIL;
+ Map<String, String> params = scanParams.getMapParams();
+ String type = params.get(ScanNode.DORIS_INCREMENT_TYPE);
+ if (type != null) {
+ String info = type.toUpperCase();
+ if ("APPEND_ONLY".equals(info)) {
+ informationKind = ChangeScanInfo.InformationKind.APPEND_ONLY;
+ } else if ("MIN_DELTA".equals(info)) {
+ informationKind = ChangeScanInfo.InformationKind.MIN_DELTA;
+ } else if ("DETAIL".equals(info)) {
+ informationKind = ChangeScanInfo.InformationKind.DETAIL;
+ } else if (!"DEFAULT".equals(info)) {
+ throw new ParseException("Unsupported increment type in incr
query: " + info);
Review Comment:
so here DEFAULT will map to DETAIL. but the previous file, DEFAULT may map
to MIN_DELTA / APPEND_ONLY (dup). the DEFAULT had confused mapping, suggest
delete the DEFAULT, no a real 'DEFAULT' optional, it's always map to other
type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
