sollhui commented on code in PR #64762:
URL: https://github.com/apache/doris/pull/64762#discussion_r3489143034
##########
be/src/service/internal_service.cpp:
##########
@@ -1346,16 +1346,19 @@ void
PInternalService::report_stream_load_status(google::protobuf::RpcController
const
PReportStreamLoadStatusRequest* request,
PReportStreamLoadStatusResponse* response,
google::protobuf::Closure*
done) {
+ brpc::ClosureGuard closure_guard(done);
TUniqueId load_id;
load_id.__set_hi(request->load_id().hi());
load_id.__set_lo(request->load_id().lo());
- Status st = Status::OK();
+ Status st = request->has_status() ? Status::create(request->status()) :
Status::OK();
Review Comment:
Rechecked the current head `6d37d5fe1217e4c9e66f4cfd434f3852a232e14e`; this
is still the blocker. The final PR file list only contains
`be/src/service/internal_service.cpp`, so the claimed
`InternalServiceStreamLoadStatusTest.*` coverage is not present. Please restore
a focused BE UT for closure completion, unknown load id, and request-status
propagation before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
