0AyanamiRei commented on code in PR #64762:
URL: https://github.com/apache/doris/pull/64762#discussion_r3490346792
##########
be/src/service/internal_service.cpp:
##########
@@ -1346,16 +1346,19 @@ void
PInternalService::report_stream_load_status(google::protobuf::RpcController
const
PReportStreamLoadStatusRequest* request,
PReportStreamLoadStatusResponse* response,
google::protobuf::Closure*
done) {
+ brpc::ClosureGuard closure_guard(done);
TUniqueId load_id;
load_id.__set_hi(request->load_id().hi());
load_id.__set_lo(request->load_id().lo());
- Status st = Status::OK();
+ Status st = request->has_status() ? Status::create(request->status()) :
Status::OK();
Review Comment:
Fixed by adding `InternalServiceStreamLoadStatusTest.*` in
`be/test/service/internal_service_stream_load_status_test.cpp`.
Coverage now includes:
- closure completion and non-OK RPC response for an unknown load id
- propagation of non-OK `PReportStreamLoadStatusRequest::status` into
`StreamLoadContext::load_status_promise`
- OK RPC acknowledgement when the report is delivered to an existing context
Verified with `./run-be-ut.sh --run
--filter=InternalServiceStreamLoadStatusTest.* -j60`,
`./build-support/clang-format.sh`, `./build-support/check-format.sh`, and `git
diff --check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
