github-actions[bot] commented on code in PR #63864:
URL: https://github.com/apache/doris/pull/63864#discussion_r3532987575
##########
regression-test/suites/query_p0/ddl/show_trash/test_nereids_trash.groovy:
##########
@@ -20,6 +20,32 @@ suite("show_trash_nereids") {
checkNereidsExecute("""show trash;""")
checkNereidsExecute("""show trash on "127.0.0.1:9050";""")
Review Comment:
This still only checks that the `ON` form executes. The parser bug fixed in
this PR also executed successfully because it discarded the backend-specific
`ShowTrashCommand(backend)` and fell back to the all-backends command, so this
regression would pass with the old broken behavior. Please add an assertion
that the `ON` backend is actually preserved or used, for example a parser/unit
test that parses `show trash on "host:port"` and checks
`ShowTrashCommand.getBackend()`, or an execution test with multiple mocked
backends that verifies only the requested backend is queried.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java:
##########
@@ -99,17 +101,43 @@ public static void getTrashInfo(List<Backend> backends,
List<List<String>> infos
}
}
- List<String> backendInfo = new ArrayList<>();
- backendInfo.add(String.valueOf(backend.getId()));
-
backendInfo.add(NetUtils.getHostPortInAccessibleFormat(backend.getHost(),
backend.getHeartbeatPort()));
- if (trashUsedCapacityB != null) {
+ if (diskTrashInfos == null) {
Review Comment:
This `continue` hides the backend whenever `getDiskTrashUsedCapacity()`
fails. Before this change, `SHOW TRASH` still emitted the BackendId/Backend row
and left the capacity empty when the old `getTrashUsedCapacity()` RPC failed,
so operators could see which backend could not report trash. With the expanded
per-disk rows, a transient RPC failure now makes the backend disappear from the
result entirely, which is misleading for a diagnostic command. Please preserve
a fallback row for the backend with the disk-specific columns left
empty/unknown instead of skipping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
