Baymine commented on code in PR #65245:
URL: https://github.com/apache/doris/pull/65245#discussion_r3534583388
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/CollectList.java:
##########
@@ -102,4 +102,15 @@ public List<FunctionSignature> getSignatures() {
public Expression resultForEmptyInput() {
return new ArrayLiteral(new ArrayList<>(), this.getDataType());
}
+
+ @Override
+ public AggregateFunction convertToMultiDistinct() {
+ Preconditions.checkArgument(distinct,
Review Comment:
the else branch does pass children.get(1), so the limit is preserved and
MultiDistinctCollectList has a matching 2-arg signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
