feiniaofeiafei commented on code in PR #65245:
URL: https://github.com/apache/doris/pull/65245#discussion_r3534585142
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/CollectList.java:
##########
@@ -38,7 +38,7 @@
* AggregateFunction 'collect_list'. This class is generated by
GenerateFunction.
*/
public class CollectList extends NotNullableAggregateFunction
- implements UnaryExpression, ExplicitlyCastableSignature {
+ implements UnaryExpression, ExplicitlyCastableSignature,
SupportMultiDistinct {
Review Comment:
The capability check should take precedence over statistics and
`multi_distinct_strategy`. In
`DistinctAggStrategySelector.shouldUseMultiDistinct`, please include
unsupported distinct functions in `mustUseCte`, for example:
`containsCountDistinctMultiExpr(agg) ||
containsUnsupportedMultiDistinctFunction(agg)`. A forced or cost-selected
multi-distinct strategy must not choose a function that has no correct
multi-distinct implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
