0AyanamiRei commented on code in PR #64878:
URL: https://github.com/apache/doris/pull/64878#discussion_r3600427557
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -2079,17 +2229,16 @@ protected void modifyCommonJobProperties(Map<String,
String> jobProperties) thro
jobProperties.remove(CreateRoutineLoadInfo.MAX_BATCH_SIZE_PROPERTY));
}
- if
(jobProperties.containsKey(CreateRoutineLoadInfo.UNIQUE_KEY_UPDATE_MODE)) {
+ boolean hasExplicitUniqueKeyUpdateMode = jobProperties.containsKey(
+ CreateRoutineLoadInfo.UNIQUE_KEY_UPDATE_MODE);
+ if (hasExplicitUniqueKeyUpdateMode) {
String modeStr =
jobProperties.remove(CreateRoutineLoadInfo.UNIQUE_KEY_UPDATE_MODE);
TUniqueKeyUpdateMode newMode =
CreateRoutineLoadInfo.parseAndValidateUniqueKeyUpdateMode(modeStr);
- // Validate flexible partial update constraints when changing to
UPDATE_FLEXIBLE_COLUMNS
- if (newMode == TUniqueKeyUpdateMode.UPDATE_FLEXIBLE_COLUMNS) {
- validateFlexiblePartialUpdateForAlter();
- }
this.uniqueKeyUpdateMode = newMode;
this.isPartialUpdate = (uniqueKeyUpdateMode ==
TUniqueKeyUpdateMode.UPDATE_FIXED_COLUMNS);
this.jobProperties.put(CreateRoutineLoadInfo.UNIQUE_KEY_UPDATE_MODE,
uniqueKeyUpdateMode.name());
this.jobProperties.put(CreateRoutineLoadInfo.PARTIAL_COLUMNS,
String.valueOf(isPartialUpdate));
+ jobProperties.remove(CreateRoutineLoadInfo.PARTIAL_COLUMNS);
Review Comment:
not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
