0AyanamiRei commented on code in PR #64878:
URL: https://github.com/apache/doris/pull/64878#discussion_r3602032231
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java:
##########
@@ -2040,7 +2140,57 @@ public void gsonPostProcess() throws IOException {
}
}
- public abstract void modifyProperties(AlterRoutineLoadCommand command)
throws UserException;
+ public void modifyProperties(AlterRoutineLoadCommand command) throws
UserException {
+ writeLock();
+ try {
+ if (getState() != JobState.PAUSED) {
+ throw new DdlException("Only supports modification of PAUSED
jobs");
+ }
+ if (!command.hasTargetTable()) {
+ unprotectApplyAlter(command);
+ return;
+ }
+
+ Database db = Env.getCurrentInternalCatalog().getDbNullable(dbId);
+ if (db == null) {
+ throw new DdlException("Database not found: " + dbId);
+ }
+ db.readLock();
+ try {
+ Table table = db.getTableNullable(command.getTargetTableId());
Review Comment:
maybe not a problem，i think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
