HappenLee commented on code in PR #65788:
URL: https://github.com/apache/doris/pull/65788#discussion_r3671549438
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -1605,8 +1605,32 @@ Status
PipelineFragmentContext::_create_operator(ObjectPool* pool, const TPlanNo
auto cache_node_id =
_params.local_params[0].per_node_scan_ranges.begin()->first;
auto cache_source_id = next_operator_id();
if (_query_cache_runtime == nullptr) {
+ TQueryCacheParam runtime_param =
_params.fragment.query_cache_param;
Review Comment:
There is no need to worry about this issue. We will follow the official
release standard, and retaining only one judgment at the FE side is sufficient.
##########
be/src/runtime/query_cache/query_cache.h:
##########
@@ -257,6 +258,80 @@ class QueryCache : public LRUCachePolicy {
void insert(const CacheKey& key, int64_t version, CacheResult& result,
const std::vector<int>& solt_orders, int64_t cache_size,
int64_t delta_count = 0);
+
+ // ---- cloud presync single-flight registry (internal to
QueryCacheRuntime) ----
Review Comment:
We should uniformly abstract the logic of sync rowset, so that reading and
query cache can share the same set of code to reduce maintenance costs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
