asdf2014 commented on code in PR #65788:
URL: https://github.com/apache/doris/pull/65788#discussion_r3705098017
##########
be/src/cloud/config.cpp:
##########
@@ -38,6 +38,10 @@ DEFINE_Int64(tablet_cache_shards, "16");
DEFINE_mInt32(tablet_sync_interval_s, "1800");
DEFINE_mInt32(init_scanner_sync_rowsets_parallelism, "10");
DEFINE_mInt32(sync_rowsets_slow_threshold_ms, "1000");
+DEFINE_mInt32(query_cache_decision_sync_timeout_ms, "2000");
Review Comment:
Removed. You are right that this is a mandatory path.
##########
be/src/exec/pipeline/pipeline_fragment_context.cpp:
##########
@@ -1605,8 +1605,32 @@ Status
PipelineFragmentContext::_create_operator(ObjectPool* pool, const TPlanNo
auto cache_node_id =
_params.local_params[0].per_node_scan_ranges.begin()->first;
auto cache_source_id = next_operator_id();
if (_query_cache_runtime == nullptr) {
+ TQueryCacheParam runtime_param =
_params.fragment.query_cache_param;
Review Comment:
Removed the BE-side mirror and its two unit tests.
##########
be/src/runtime/query_cache/query_cache.h:
##########
@@ -257,6 +258,80 @@ class QueryCache : public LRUCachePolicy {
void insert(const CacheKey& key, int64_t version, CacheResult& result,
const std::vector<int>& solt_orders, int64_t cache_size,
int64_t delta_count = 0);
+
+ // ---- cloud presync single-flight registry (internal to
QueryCacheRuntime) ----
Review Comment:
Agree with the direction; taking it as a follow-up sounds right so the scope
of this PR stays contained. Happy to work on that after this lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
