Gabriel39 commented on code in PR #66221:
URL: https://github.com/apache/doris/pull/66221#discussion_r3701682253
##########
docker/compilation/Dockerfile.gcc7:
##########
@@ -46,8 +46,8 @@ RUN yum install -y bzip2 wget git gcc-c++ libstdc++-static
byacc flex automake l
ENV PATH ${DEFAULT_DIR}/node-v14.16.0-linux-x64/bin:$PATH
# build cmake
-ARG CMAKE_VERSION=3.12.3
-ARG
CMAKE_DOWNLOAD_URL=https://cmake.org/files/v3.12/cmake-${CMAKE_VERSION}.tar.gz
+ARG CMAKE_VERSION=3.25.3
Review Comment:
[P1] Please upgrade the compiler in this image together with CMake, or
retire the image. Arrow 24 sets `CMAKE_CXX_STANDARD` to 20 and marks it as
required, while CMake 3.25 only defines the GNU C++20 dialect for GCC 8 and
newer. This file still installs GCC 7.3, so `thirdparty/build-thirdparty.sh`
cannot configure or build Arrow 24. A direct reproduction with GCC 7.5 fails
with `g++: error: unrecognized command line option '-std=c++20'`. Please use a
compiler version supported by Doris (preferably GCC 11.1 or newer) and add a
build check for this image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
