github-actions[bot] commented on code in PR #66221: URL: https://github.com/apache/doris/pull/66221#discussion_r3706622865
########## be/cmake/thirdparty.cmake: ########## @@ -105,6 +105,7 @@ add_thirdparty(brotlidec LIB64) add_thirdparty(brotlienc LIB64) add_thirdparty(zstd LIB64) add_thirdparty(arrow LIB64) +add_thirdparty(arrow_compute LIB64) Review Comment: [P1] Validate ordinary third-party installs before importing Compute The new validator is only used by the macOS workflow. A normal checkout built on the base revision still has `build.sh`'s final third-party sentinel, but its Arrow 17 install has no `libarrow_compute.a`; after switching to this head, `build.sh:450-466` skips `build-thirdparty.sh` and this unconditional target points at a missing archive. Generic downloaded prebuilts follow the same unchecked path. This is distinct from the existing scheduled-macOS thread because it affects ordinary cross-platform `build.sh` and prebuilt consumers. Validate the Arrow/Paimon component fingerprints before accepting an existing installation (and rebuild the closure when invalid), and publish matching generic prebuilts before making Compute mandatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
