924060929 commented on PR #65851: URL: https://github.com/apache/doris/pull/65851#issuecomment-5177985569
Scope clarification after follow-up: the V1 Iceberg reader path is no longer part of the acceptance scope for this PR. I am therefore withdrawing the V1-only findings in be/src/format/table/iceberg_reader.cpp and resolving those review threads; they should not block this change. The b3fd815 V1 wrapper fix looks consistent with the shared mapper, but V1 behavior is no longer a merge criterion here.\n\nThis does not clear the current request-changes decision. The remaining FE, plugin-scan, V2, and write-path findings are independent of V1, including the prepared-statement schema state, nullable MERGE omission, V2 typed/complex defaults, backslash round-trip, V2 missing-root materialization, projection/applicable-delete upgrade fences, INSERT OVERWRITE pinning, nullable ORC collection handling, and the snapshot-history P2. Those still need to be resolved or explicitly scoped separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
