Copilot commented on code in PR #66940:
URL: https://github.com/apache/doris/pull/66940#discussion_r3811057071
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3414,7 +3414,12 @@ public static int metaServiceRpcRetryTimes() {
public static int meta_service_rpc_timeout_retry_times = 1;
@ConfField(mutable = true, description = "Whether to enable QPS rate limit
for RPC requests to meta service.")
- public static boolean meta_service_rpc_rate_limit_enabled = false;
+ public static boolean meta_service_rpc_rate_limit_enabled = true;
+
+ @ConfField(mutable = true, description = "Whether to only evaluate and
report meta service RPC rate limits "
+ + "without waiting or rejecting requests. This takes effect only
when meta service RPC rate limiting "
+ + "is enabled.")
+ public static boolean meta_service_rpc_rate_limit_dry_run = true;
Review Comment:
Setting `meta_service_rpc_rate_limit_dry_run` default to `true` changes the
semantics for operators who explicitly enable rate limiting (it will silently
not enforce limits unless they also turn off dry-run). If dry-run is intended
as an evaluation mode, it should be opt-in via configuration rather than the
default.
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3414,7 +3414,12 @@ public static int metaServiceRpcRetryTimes() {
public static int meta_service_rpc_timeout_retry_times = 1;
@ConfField(mutable = true, description = "Whether to enable QPS rate limit
for RPC requests to meta service.")
- public static boolean meta_service_rpc_rate_limit_enabled = false;
+ public static boolean meta_service_rpc_rate_limit_enabled = true;
Review Comment:
This changes the default for `meta_service_rpc_rate_limit_enabled` from
`false` to `true`, which is a behavior change not mentioned in the PR
description. Even with dry-run, enabling the limiter by default can introduce
overhead and surprise operators who have not opted in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
