gavinchou commented on code in PR #66940:
URL: https://github.com/apache/doris/pull/66940#discussion_r3811228162


##########
fe/fe-core/src/main/java/org/apache/doris/metric/CloudMetrics.java:
##########
@@ -66,15 +66,18 @@ public class CloudMetrics {
     public static AutoMappedMetric<LongCounterMetric> META_SERVICE_RPC_TOTAL;
     public static AutoMappedMetric<LongCounterMetric> META_SERVICE_RPC_FAILED;
     public static AutoMappedMetric<LongCounterMetric> 
META_SERVICE_RPC_RATE_LIMITED;
+    public static AutoMappedMetric<LongCounterMetric> 
META_SERVICE_RPC_RATE_LIMIT_DRY_RUN_REJECTED;

Review Comment:
   the name should not contains `dryrun`, because when we are not running in 
`dry run` mode, the throttled metrics should be recorded too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to