eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3900160737
##########
be/src/exec/operator/hashjoin_build_sink.cpp:
##########
@@ -584,7 +584,7 @@ Status
HashJoinBuildSinkLocalState::process_build_block(RuntimeState* state, Blo
SCOPED_TIMER(_build_table_timer);
auto rows = (uint32_t)block.rows();
// 1. Dispose the overflow of ColumnString
- // 2. Finalize the ColumnVariant to speed up
+ // 2. Finalize the Variant column to speed up
for (auto& data : block) {
data.column =
IColumn::mutate(std::move(data.column))->convert_column_if_overflow();
if (p._need_finalize_variant_column) {
Review Comment:
这里的 finalize 逻辑应该也不需要了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
