eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r3900319829


##########
be/src/storage/segment/variant/binary_column_extract_iterator.cpp:
##########
@@ -19,79 +19,52 @@
 
 #include "core/column/column_nullable.h"
 #include "core/column/column_string.h"
-#include "core/column/column_variant.h"
 #include "core/column/variant_column_utils.h"
+#include "storage/segment/variant/v2/variant_assembler.h"
 #include "storage/segment/variant/v2/variant_column_reader.h"
-#include "storage/segment/variant/v2/variant_storage_cell.h"
+#include "util/json/path_in_data.h"
 
 namespace doris::segment_v2 {
 
 BinaryColumnExtractIterator::BinaryColumnExtractIterator(std::string_view path,
                                                          BinaryColumnCacheSPtr 
sparse_column_cache,
                                                          const 
StorageReadOptions* opts,
                                                          bool use_variant_v2)

Review Comment:
   use_variant_v2 是不是可以删了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to