Gabriel39 commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r3979473945
##########
be/src/format_v2/parquet/reader/native_column_reader.cpp:
##########
@@ -202,6 +202,24 @@ const NativeFieldSchema* find_child_field(const
NativeFieldSchema& parent,
return field_it == parent.children.end() ? nullptr : &*field_it;
}
+Status sync_native_field_types(const ParquetColumnSchema& schema,
NativeFieldSchema* field) {
+ DORIS_CHECK(field != nullptr);
+ field->data_type = schema.type;
Review Comment:
Fixed in 9a525689f8. Request-level type synchronization now keeps a Variant
field bound to its physical STRUCT (including the request-adjusted physical
type) while recursively updating its children. I also added a regression test
that verifies an unshredded Variant remains a physical STRUCT after
synchronization.
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -655,7 +655,10 @@ struct TFileScanRangeParams {
34: optional i32 iceberg_scan_semantics_version
// FE-generated identity for sharing a deserialized table across JNI
scanners in one scan node.
35: optional string serialized_table_cache_key
- // 31-33 and 36 are used in master; do not allocate them in branch-4.1.
+ // HMS catalog property hive.parquet.time-zone. When absent, format_v2
keeps INT96 wall-clock
Review Comment:
Fixed in 9a525689f8. The plan now carries a versioned Parquet
timestamp-semantics marker: marker absence preserves legacy session-timezone
INT96 decoding for old FE plans, while version 1 distinguishes an explicit
empty override from a named timezone. Hudi sends its session zone explicitly,
and rolling-upgrade regression coverage was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
