Gabriel39 commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r3985438925
##########
be/src/core/data_type_serde/data_type_string_serde.cpp:
##########
@@ -464,6 +466,45 @@ Status
DataTypeStringSerDeBase<ColumnType>::write_column_to_arrow(
}
}
+template <typename ColumnType>
+Status DataTypeStringSerDeBase<ColumnType>::write_column_to_iceberg(
+ const std::shared_ptr<const IDataType>& type, const IColumn& column,
+ const NullMap* null_map, const std::shared_ptr<arrow::Field>& field,
+ arrow::ArrayBuilder* array_builder, int64_t start, int64_t end,
Review Comment:
This is an old-FE/new-BE rolling-upgrade compatibility issue. Per the scope
decision for this branch fix, we will not preserve this compatibility path. New
FEs always plan Iceberg fixed(N) as VARBINARY, so no change will be made here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
