Gabriel39 commented on code in PR #67904:
URL: https://github.com/apache/doris/pull/67904#discussion_r3999440657
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergConnectorMetadata.java:
##########
@@ -499,17 +500,24 @@ public ConnectorTableSchema getTableSchema(
schema = table.schema();
}
}
- return buildTableSchema(iceHandle.getTableName(), table, schema, true);
+ String specId =
snapshot.getProperties().get(PARTITION_SPEC_ID_PROPERTY);
Review Comment:
Fixed in 1cf784fb4a.
This is in scope: retaining the schema ID for snapshot-less latest pins in
this PR makes the old currentSnapshot() bypass inconsistent with the pinned
partition spec.
Both getTableSchema and getColumnHandles now use one schema-ID resolver
regardless of whether the table has a data snapshot. The existing missing-ID
fallback is shared and remains aligned with the scan provider. A warm-cache
test renames the partition source column while the table is empty and checks
the pinned columns, partition metadata, and column handles before and after the
first append. A second test checks the missing-ID fallback. The new evolution
test failed on the previous code; all 251 tests in the metadata, MVCC, and
scan-provider test classes now pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
