Gabriel39 commented on PR #67904: URL: https://github.com/apache/doris/pull/67904#issuecomment-5652894719
Fixed the Iceberg failures in 1cf784fb4a. The eager latest-schema pin introduced by this PR made the MVCC guard compare the request-scoped `__DORIS_ICEBERG_ROWID_COL__` against the physical schema. This rejected hidden-column reads and DML before scan planning. The guard now honors the connector's SYNTHESIZED classification on a schema miss, while retaining checks for real and GENERATED columns. The same commit fixes the reviewed empty-table cached-schema bypass in both schema and column-handle lookup. Validation: all 29 previously failing Iceberg regression suites passed locally on the final code, with unchanged baselines. All 234 related FE tests and 251 Iceberg metadata/MVCC/scan-provider tests passed; the FE build and Checkstyle passed. Both regressions were reproduced before their fixes. The earlier Paimon failures already passed in the subsequent external-regression build. The old coverage failure was caused by the compile artifact not yet being available; it is a CI dependency/timing issue and does not require a product change here. Historical Iceberg partition-view/spec-cache isolation remains outside this PR, as documented in the resolved review thread. `run buildall` and `/review` have been posted for the new commit. The new remote compile and FE UT are still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
