HappenLee commented on code in PR #67894:
URL: https://github.com/apache/doris/pull/67894#discussion_r4002329052
##########
be/src/exec/sort/partition_sorter.cpp:
##########
@@ -154,6 +154,7 @@ Status PartitionSorter::_read_row_num(Block* output_block,
bool* eos, int batch_
}
Status PartitionSorter::_read_row_rank(Block* output_block, bool* eos, int
batch_size) {
+ *eos = false;
Review Comment:
After discussing this finding, we are retaining the existing cancellation
polling points for this change. Cancellation during synchronous intermediate
pruning may only be observed after the current pass returns; the final
preparation loops also remain unchanged. We accept that cancellation-latency
trade-off for this PR and will not add per-block or per-batch polling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
