HappenLee commented on code in PR #67894:
URL: https://github.com/apache/doris/pull/67894#discussion_r4002363642
##########
be/src/exec/sort/partition_sorter.cpp:
##########
@@ -182,6 +177,7 @@ Status PartitionSorter::_read_row_rank(Block* output_block,
bool* eos, int batch
// rank() maybe need check when have get a distinct row
// so when the cmp_res is get a distinct row, need check have
output all rows num
if (_get_enough_data()) {
+ *eos = true;
Review Comment:
Fixed in f0f5b0db58d7f41fc15372a47411edd4aba25c55. SortCursorCmp::reset now
calls impl.reset() and sets row to zero, so a new sorting pass starts without a
previous peer group. The lower-level MergeSortCursorImpl::reset semantics
remain unchanged. Added a comment explaining why rewinding the old cursor is
insufficient, plus a two-pass reuse test for both RANK and DENSE_RANK with the
same leading key across passes and a peer group spanning output batches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
