eldenmoon commented on code in PR #66858: URL: https://github.com/apache/doris/pull/66858#discussion_r4002955485
########## be/src/core/column/column_variant.h: ########## @@ -1,688 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. -// This file is copied from -// https://github.com/ClickHouse/ClickHouse/blob/master/src/Columns/ColumnVariant.h -// and modified by Doris - -#pragma once -#include <butil/compiler_specific.h> -#include <glog/logging.h> -#include <rapidjson/document.h> -#include <rapidjson/stringbuffer.h> -#include <sys/types.h> - -#include <algorithm> -#include <memory> -#include <ostream> -#include <string> -#include <string_view> -#include <unordered_set> -#include <utility> -#include <vector> - -#include "common/status.h" -#include "core/column/column.h" -#include "core/column/column_map.h" -#include "core/column/column_nullable.h" -#include "core/column/column_vector.h" -#include "core/column/subcolumn_tree.h" -#include "core/cow.h" -#include "core/data_type/data_type.h" -#include "core/data_type/data_type_array.h" -#include "core/data_type/data_type_jsonb.h" -#include "core/data_type/data_type_map.h" -#include "core/data_type/data_type_nullable.h" -#include "core/data_type/data_type_variant.h" -#include "core/data_type_serde/data_type_serde.h" -#include "core/field.h" -#include "core/string_ref.h" -#include "core/types.h" -#include "storage/tablet/tablet_schema.h" -#include "util/json/path_in_data.h" - -class SipHash; - -namespace doris { -class Arena; -} // namespace doris - -namespace doris { - -#ifdef NDEBUG -#define ENABLE_CHECK_CONSISTENCY (void)/* Nothing */ -#else -#define ENABLE_CHECK_CONSISTENCY(this) (this)->check_consistency() -#endif - -/** A column that represents object with dynamic set of subcolumns. - * Subcolumns are identified by paths in document and are stored in - * a trie-like structure. ColumnVariant is not suitable for writing into tables - * and it should be converted to Tuple with fixed set of subcolumns before that. - */ -class ColumnVariant final : public COWHelper<IColumn, ColumnVariant> { Review Comment: fixed in next PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
