eldenmoon commented on code in PR #66858:
URL: https://github.com/apache/doris/pull/66858#discussion_r4002962095
##########
be/src/storage/segment/variant/variant_column_writer_impl.cpp:
##########
@@ -1797,59 +431,29 @@ VariantColumnWriterImpl::~VariantColumnWriterImpl() =
default;
Status VariantColumnWriterImpl::init() {
DORIS_CHECK(!_initialized);
_initialized = true;
- if (can_use_nested_group_streaming_compaction(_opts, *_tablet_column)) {
- return _initialize_v1_writer();
- }
- return Status::OK();
-}
-
-Status VariantColumnWriterImpl::_initialize_v1_writer() {
- DORIS_CHECK(_initialized);
- DORIS_CHECK(_input_format == VariantWriterInputFormat::UNSET);
- auto writer = std::make_unique<VariantV1ColumnWriter>(_opts,
_tablet_column);
- RETURN_IF_ERROR(writer->init());
- _v1_writer = std::move(writer);
- _input_format = VariantWriterInputFormat::V1;
- return Status::OK();
+ return _ensure_writer();
}
-Status VariantColumnWriterImpl::_ensure_writer(const VariantColumnData&
column) {
+Status VariantColumnWriterImpl::_ensure_writer() {
DORIS_CHECK(_initialized);
- VariantWriterInputFormat input_format;
- RETURN_IF_ERROR(variant_writer_helpers::classify_variant_writer_input(
- column, _input_format, "Variant writer", &input_format));
- if (_input_format != VariantWriterInputFormat::UNSET) {
+ if (_v2_writer) {
return Status::OK();
}
-
- if (input_format == VariantWriterInputFormat::V1) {
- RETURN_IF_ERROR(_initialize_v1_writer());
- } else {
- auto writer = std::make_unique<VariantV2ColumnWriter>(_opts,
_tablet_column);
- RETURN_IF_ERROR(writer->init());
- _v2_writer = std::move(writer);
- }
- _input_format = input_format;
+ auto writer = std::make_unique<VariantV2ColumnWriter>(_opts,
_tablet_column);
Review Comment:
deprecated_variant_enable_flatten_nested 不维护了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
