Gabriel39 commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4011103474
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/source/JdbcScanNode.java:
##########
@@ -285,6 +285,13 @@ public int getNumInstances() {
}
private static boolean shouldPushDownConjunct(TOdbcTableType tableType,
Expr expr) {
+ // These dialects do not accept Doris X'...' as binary literals
(PostgreSQL reads bit
+ // strings). Keep the conjunct local without disabling MySQL's
compatible binary syntax.
+ if ((tableType == TOdbcTableType.POSTGRESQL || tableType ==
TOdbcTableType.ORACLE
Review Comment:
Fixed in acd7d63c0d. Added DB2 and OCEANBASE_ORACLE to the local-evaluation
fence. Extended the dialect matrix to cover comparisons, IN/NOT IN, empty and
non-UTF-8 binary literals, and compound predicates while preserving numeric
predicate and MySQL pushdown. JdbcScanNodeTest passes (26 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
