github-actions[bot] commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4012207350
##########
be/src/exec/operator/file_scan_operator.cpp:
##########
@@ -147,9 +148,23 @@ bool FileScanLocalState::should_use_file_scanner_v2(const
TQueryOptions& query_o
const bool is_transactional_hive =
scan_params.__isset.table_format_params &&
scan_params.table_format_params.table_format_type ==
"transactional_hive";
- return query_options.__isset.enable_file_scanner_v2 &&
query_options.enable_file_scanner_v2 &&
- !is_load && scan_params.format_type !=
TFileFormatType::FORMAT_ES_HTTP &&
- !is_transactional_hive;
+ const bool is_paimon_native_parquet = scan_params.format_type ==
TFileFormatType::FORMAT_JNI &&
+
scan_params.__isset.contains_native_parquet &&
+ scan_params.contains_native_parquet;
+ const bool requires_parquet_timestamp_contract =
Review Comment:
[P1] Account for mixed-format Iceberg ranges when forcing V2
This decision only sees `scan_params.format_type`, which Iceberg fills from
the table's current `write.format.default`; each `IcebergSplit` then overrides
`TFileRangeDesc.format_type` with the data file's actual format. After changing
a table default from Parquet to ORC, retained Parquet/INT96 files therefore
have scan-level ORC. With `enable_file_scanner_v2=false`, this leaves the scan
on V1, which ignores the explicit-empty/version-1 wall-clock contract and
decodes those files in the session timezone. Please make actual-Parquet
presence available before scanner construction (including batch/remote splits),
or make scanner selection range-aware, and cover an ORC-default Iceberg table
containing a Parquet range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
