Gabriel39 commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4016839406
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogProperty.java:
##########
@@ -103,18 +104,20 @@ public Map<String, String> getProperties() {
}
/**
- * @return true if varbinary mapping is enabled, false otherwise
+ * @return true because external binary types always retain their binary
semantics
*/
+ @Deprecated
public boolean getEnableMappingVarbinary() {
- return Boolean.parseBoolean(getOrDefault(ENABLE_MAPPING_VARBINARY,
"false"));
+ return true;
Review Comment:
Addressed in e8936a349b. The unconditional VARBINARY mapping is retained.
This adds byte-preserving comparison/coercion, grouping and distinct keys,
single/composite and null-aware joins, views, CTAS, and MTMV creation/refresh,
including native storage for nested binary leaves. It also fixes trailing-NUL
literal ordering, long-value ownership, short-key bounds, conservative binary
zone maps, and declared byte-length validation.
The Hive regression now executes these consumers on the original binary
column and checks both VARBINARY metadata and byte-exact results. The Paimon
views again expose all original columns. A new native SQL suite covers
NULL/empty/high-byte/prefix values, long values across pages, nested CTAS,
repeated MTMV refresh, and oversize-value rejection.
Local verification before committing: 62 FE tests, 99 BE tests, and the
complete test_varbinary_sql_support, test_hive_orc, and test_paimon_catalog
suites passed. FE Checkstyle and clang-format 16 checks passed. Binary-key
runtime filters remain disabled because their transport is text-only; the joins
themselves execute on binary keys without STRING fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
