yiguolei commented on code in PR #67784:
URL: https://github.com/apache/doris/pull/67784#discussion_r4014734950
##########
be/src/core/data_type_serde/data_type_serde.h:
##########
@@ -498,6 +499,23 @@ class DataTypeSerDe {
virtual Status write_column_to_arrow(const IColumn& column, const NullMap*
null_map,
arrow::ArrayBuilder* array_builder,
int64_t start,
int64_t end, const cctz::time_zone&
ctz) const = 0;
+ // Most scalar types deliberately share their physical Arrow encoding
across these protocols.
+ // Target-specific SerDes override the corresponding method; callers never
retry another
+ // protocol method after an error.
+ virtual Status write_column_to_paimon(const std::shared_ptr<const
IDataType>&,
Review Comment:
rename write_column_to_paimon_arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
