HappenLee commented on PR #68219: URL: https://github.com/apache/doris/pull/68219#issuecomment-5740710090
/review Please review the updated head fcb26e2e742a1d77cbb61e856b98cbe9de2f5460, especially the P2 scratch-allocation fix from https://github.com/apache/doris/pull/68219#discussion_r4052727433. Removed both eager `values.reserve(batch_size)` calls. The existing tracked PaddedPODArray now grows only when a non-NULL, nonnegative row survives, so all-NULL/all-negative batches allocate no scratch buffer. The direct all-nonnegative `add_many` fast path is unchanged. Dense filtered input uses the container's existing geometric growth; no extra filtering pass was added. The previously agreed scope remains unchanged: backward compatibility for persisted experimental AGG_STATE data is out of scope. This follow-up addresses P2 only; the separate mixed-version rolling-upgrade concern is not changed by these two deletions. Validation: clang-format 16, check-format, BE header hygiene, git diff --check and syntax-only compilation of the bitmap_agg registration translation unit passed. Existing unit tests cover all-NULL, all-negative, mixed-sign and nonnegative inputs for all four signed integer widths. Local unit tests were not rerun because the previous ASAN UT build is blocked by the missing AWS GeneralHTTPCredentialsProvider.h dependency. clang-tidy was attempted and remains blocked by pre-existing diagnostics, including an unmatched NOLINTEND in core/types.h. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
