github-actions[bot] commented on code in PR #69007: URL: https://github.com/apache/doris/pull/69007#discussion_r4309747978
########## cloud/src/common/config.h: ########## @@ -312,7 +312,7 @@ CONF_mBool(enable_load_txn_status_check, "true"); CONF_mBool(enable_tablet_job_check, "true"); -CONF_mBool(enable_recycle_delete_rowset_key_check, "true"); +CONF_mBool(enable_commit_rowset_recycle_key_idempotency_check, "true"); Review Comment: [P2] Preserve the existing recycle-key configuration name `CONF_mBool` uses the field name as the external config key. Removing `enable_recycle_delete_rowset_key_check` therefore silently ignores an existing `enable_recycle_delete_rowset_key_check=false` in both primary and persisted custom config files: `config::init()` visits only registered names, leaving the replacement at its `true` default. Existing `/update_config` requests with the old name also fail with `INVALID_ARGUMENT`. An upgrade consequently switches non-delete rowsets from the selected transaction/job fallback to recycle-key enforcement without any operator config change. Preserve the old registered key or provide an alias/migration for startup loading and dynamic updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
