OIiveirra commented on code in PR #69527:
URL: https://github.com/apache/doris/pull/69527#discussion_r4367696473
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/S3TableValuedFunction.java:
##########
@@ -63,6 +64,11 @@ public S3TableValuedFunction(Map<String, String> properties,
List<TBrokerFileSta
} catch (UserException e) {
throw new RuntimeException(e);
}
+ // Validate the final URI, including when BrokerProperties passes it
through unchanged.
+ // A local dataset must not bypass the LOCAL switch, privileges or BE
secure directory.
+ if (isLanceFormat() && !LanceTvfStoragePolicy.isRemoteUri(filePath)) {
Review Comment:
Fixed in b926f4b9c834c37ea144e8d9f924e378ad54755d and mirrored to the other
active PRs after confirming the same consumer path. S3 TVFs now apply Hadoop
read admission when the normalized storage is Hadoop-compatible, including the
OSS-HDFS family, before listing and before either constructor branch can
return. Every listed or supplied file path is checked again before schema/data
use.
New CSV/declared-schema tests reject local delegation with LOCAL both
disabled and enabled, reject supplied local file paths in normal/unit-test
branches, and preserve remote CSV schema plus FILE_HDFS range classification.
Plain S3 and OSS-HDFS controls remain available. Before tests reproduced the
unguarded route; all 65 selected FE tests and Checkstyle pass with fresh XML,
zero failures/errors/skips and unchanged inputs. Tests use controlled
listings/factory mocks, with no real local-file read. BE, SDK and generic
filesystem/catalog code are unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
