yujun777 commented on PR #69850:
URL: https://github.com/apache/doris/pull/69850#issuecomment-6852489084
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69850
commit: b78642cd9bed2ce8b3a98607fe9df9bed9a3e2b7
base: ee73acc6131e6c6c752eb59e252404590be6ad77
reviewed_at: 2026-11-13T20:11+08:00
reviewer: yujun777
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/OlapTableStream.java:60`
— Reviewed full31-path Part I scope: one persisted offset/B0/C0 tuple,
precommit sampling, transient source validity and existing FE/MS baseline
metadata. Prior five findings are fixed; all severities currently zero.
Column-stat transforms and current-count collection are excluded.
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/TableStreamManager.java:337`
— Consumption capture uses zero-wait locks; successful cloud publication takes
only stream tryWrite(0), with no source lock or resampling. Equal consumed
offset retains counts; replay keeps raw values and clears validity.
-
`fe/fe-core/src/test/java/org/apache/doris/nereids/stats/StreamScanRowCountTest.java:326`
— Inspected existing passing evidence:144 distinct FE tests,42 native MemTxnKv
tests and17 shared-nothing regression suites; FE/Cloud builds and changed-line
C++ checks. No builds/tests were run during this read-only review.
- `gensrc/proto/cloud.proto:599` — Six optional fields across three existing
messages were compared with master/four maintained releases. No live-cloud
new-baseline-protocol, real FDB/process-restart, combined-PR runtime or
benchmark was performed; companion older binaries/version1f556 and
conflict-free merge applicability do not prove those results.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:489`
— Estimates follow the accepted asynchronous-report/TTL approximation and
ordinary unknown floor; no strict upper bound. Existing direct base
t@incr/base-only injection thread remains preexisting/outside the stream
entry-point scope. Unreleased local stream JSON migration is explicitly out of
scope.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
