yujun777 commented on PR #69850:
URL: https://github.com/apache/doris/pull/69850#issuecomment-6857607121
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69850
commit: 54c5ef1bb7a2fd8209d9edea633020179a550b0a
base: ee73acc6131e6c6c752eb59e252404590be6ad77
reviewed_at: 2026-11-13T23:36+08:00
reviewer: yujun777
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/OlapTableStreamUpdate.java:35`
— Full36-path Part I review: named PartitionUpdate with compact u/p/n, single
named-state-map constructors, nullable-field domains, preserved merge/CAS and
source validity. All original five findings remain fixed; current findings all
zero.
-
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/OlapTableStream.java:74`
— One private complete PS constructor with constant-only immutable initial
seed and restored factory; offset/B0/C0 persist together, precommit sampling
freezes values, replay preserves counts and clears binding. Postcommit cloud
publication uses only zero-time stream WRITE, no source lock or resampling.
- `regression-test/suites/changelog_p0/test_stream_scan_row_count.groovy:87`
— Inspected latest199 FE tests/13 classes and17 SN suites, all zero failures;
actual SN report HTTP200 then FE aggregate polling. Cloud skips only the
unsupported HTTP trigger. Actual FEjar API and build/style evidence checked; no
review-time builds/tests.
- `gensrc/proto/cloud.proto:599` — Six optional baseline fields checked on
master/four releases; native/proto blobs equal prior approved source, so
earlier42 MemTxnKv/ASAN evidence is inherited, not rerun. No live-cloud
new-baseline-protocol, real FDB/process restart, combined runtime/current-head
combined merge check, IPv6 execution or benchmark was performed.
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:489`
— Accepted asynchronous-report/TTL approximation and ordinary unknown floor
remain; no strict upper bound or column-stat/current-count collection work.
Existing direct base t@incr/base-only injection thread and unreleased old JSON
migration remain outside scope. Earlier-head/companion binary evidence is not
final protocol/runtime proof.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
