leventov commented on a change in pull request #6349: maintenance mode for
Historical
URL: https://github.com/apache/incubator-druid/pull/6349#discussion_r221426981
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java
##########
@@ -100,8 +101,12 @@ public CoordinatorDynamicConfig(
this.killDataSourceWhitelist =
parseJsonStringOrArray(killDataSourceWhitelist);
Review comment:
Could you please rename `killDataSourceWhitelist` and
`killPendingSegmentsSkipList` parameters, fields and getters to not mention
"list" and the latter to mention "dataSource" (it's actual elements), while
JSON property names could stay the same for compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
